Skip to content

Conversation

@heyuanjie87
Copy link
Contributor

@heyuanjie87 heyuanjie87 commented Nov 22, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Fixed #9566

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@heyuanjie87 heyuanjie87 marked this pull request as draft November 22, 2024 11:42
@github-actions github-actions bot added BSP Arch: RISC-V BSP related with risc-v libcpu labels Nov 22, 2024
@unicornx
Copy link
Contributor

unicornx commented Nov 26, 2024

这个 pr 是针对解决 #9566 吗?

如果是的话,请在上面 PR 的描述中(即 “拉取/合并请求描述:(PR description)” 下面的文字中)加上一行:

Fixed #9566

这样就可以将 PR 和 issue 关联起来,当这个 PR 被 merge 时,关联的 issue 就会自动被关闭。

@heyuanjie87 heyuanjie87 marked this pull request as ready for review November 26, 2024 09:04
@heyuanjie87 heyuanjie87 marked this pull request as draft November 26, 2024 09:04
@BernardXiong BernardXiong requested a review from polarvid December 1, 2024 10:54
@BernardXiong
Copy link
Member

这份PR可否推动起来?🙇

@polarvid
Copy link
Contributor

polarvid commented Jan 2, 2025

PR 包含冲突,且处于草稿状态。不太确定作者是否还需要接着修改呢。

@heyuanjie87 还请再确认一下,谢谢。

@zhangjing0303
Copy link
Contributor

interrupt.c中定义了rt_hw_interrupt_install这类外部接口,是否可以把每个cpu下的interrupt.c也一起统一?

@heyuanjie87
Copy link
Contributor Author

PR 包含冲突,且处于草稿状态。不太确定作者是否还需要接着修改呢。

@heyuanjie87 还请再确认一下,谢谢。

还要改的,还没在双核上验证

@heyuanjie87
Copy link
Contributor Author

interrupt.c中定义了rt_hw_interrupt_install这类外部接口,是否可以把每个cpu下的interrupt.c也一起统一?

等我把plic统一了就考虑你的建议

@heyuanjie87
Copy link
Contributor Author

这份PR可否推动起来?🙇

得等其他事忙完了,或者也可以看看其他人有没空推动下这个

@heyuanjie87
Copy link
Contributor Author

已有新的pr替代

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v BSP libcpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] risc-v: 统一 PLIC 支持 | Unify the PLIC

5 participants