Skip to content

fix : libcpu : change RISCV_S_MODE to libcpu #9718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WwWangGuan wants to merge 6 commits into from
Closed

fix : libcpu : change RISCV_S_MODE to libcpu #9718

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b6d358
[bsp][gd32][fix rtc clock selection]
WwWangGuan Nov 13, 2024
2e11005
[fix]将RISCV_S_MODE配置开关移至libc中
WwWangGuan Nov 27, 2024
e6f8153
fix : libc : change RISCV_S_MODE to libc
WwWangGuan Nov 27, 2024
1917fe1
Merge branch 'RT-Thread:master' into features
WwWangGuan Nov 28, 2024
d518916
Merge branch 'features' of https://github.com/WwWangGuan/rt-thread in…
WwWangGuan Dec 2, 2024
5c838f4
Merge branch 'RT-Thread:master' into features
WwWangGuan Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bsp/qemu-virt64-riscv/driver/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
menu "RISC-V QEMU virt64 configs"

config RISCV_S_MODE
bool "RT-Thread run in RISC-V S-Mode(supervisor mode)"
default y

config RT_USING_VIRTIO
bool "Using VirtIO"
Expand Down
6 changes: 6 additions & 0 deletions libcpu/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ if ARCH_RISCV64
select ARCH_USING_NEW_CTX_SWITCH
help
Using the common64 implementation under ./libcpu/risc-v

config RISCV_S_MODE
bool "RT-Thread run in RISC-V S-Mode(supervisor mode)"
depends on BOARD_QEMU_VIRT_RV64
Copy link
Contributor

@unicornx unicornx Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libcpu 依赖 bsp？ 这个关系反过来了吧？

Copy link
Contributor Author

@WwWangGuan WwWangGuan Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libcpu 依赖 bsp？ 这个关系反过来了吧？

不是依赖，不写这个depend on 会导致RISCV_S_MODE宏定义在所有调用了ARCH_RISCV_64的menuconfig中显示配置选项

Copy link
Contributor

@unicornx unicornx Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RISCV_S_MODE 现在移到 libcpu 中就是意味着这个配置对所有 riscv64 可见了，这本身没有问题啊

default y

endif

config ARCH_REMAP_KERNEL
Expand Down