Skip to content

fix: add \n for addr2line hint #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mysterywolf merged 1 commit into from
Jan 8, 2025
Merged

fix: add \n for addr2line hint #9882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/lwp/lwp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,12 +664,12 @@ rt_err_t lwp_backtrace_frame(rt_thread_t uthread, struct rt_hw_backtrace_frame *
argv = lwp_get_command_line_args(lwp);
if (argv)
{
rt_kprintf("please use: addr2line -e %s -a -f", argv[0]);
rt_kprintf("please use: addr2line -e %s -a -f\n", argv[0]);
lwp_free_command_line_args(argv);
}
else
{
rt_kprintf("please use: addr2line -e %s -a -f", lwp->cmd);
rt_kprintf("please use: addr2line -e %s -a -f\n", lwp->cmd);
}

while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)
Expand Down
2 changes: 1 addition & 1 deletion libcpu/arm/cortex-a/backtrace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
arm_get_current_stackframe(regs, &frame);

#ifndef RT_BACKTRACE_FUNCTION_NAME
rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
#endif
LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);

Expand Down
2 changes: 1 addition & 1 deletion libcpu/arm/cortex-r52/backtrace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
arm_get_current_stackframe(regs, &frame);

#ifndef RT_BACKTRACE_FUNCTION_NAME
rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
#endif
LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);

Expand Down
4 changes: 2 additions & 2 deletions src/kservice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
{
long nesting = 0;

rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");

while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)
{
Expand All @@ -446,7 +446,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
*/
rt_weak rt_err_t rt_backtrace_formatted_print(rt_ubase_t *buffer, long buflen)
{
rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");

for (rt_size_t i = 0; i < buflen && buffer[i] != 0; i++)
{
Expand Down
Loading