Mapping FHS new version updated - moving from v33 to v35#358
Merged
amc-corey-cox merged 7 commits intomainfrom Feb 24, 2026
Merged
Mapping FHS new version updated - moving from v33 to v35#358amc-corey-cox merged 7 commits intomainfrom
amc-corey-cox merged 7 commits intomainfrom
Conversation
Collaborator
|
I'm about to add another PR that will conflict with this for temporal stuff. @diatomsRcool If you don't mind I'll review and merge this so I can do the temporal fix. |
Collaborator
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
Reviewed the full diff. The v33→v35 changes look good:
name:→value:rename is consistent across all 113 files that needed it- phv remappings for the version change look systematic
- pht006027 decomposition into specific tables (pht000039, pht009761, pht007777, pht006026) makes sense for v35
VALIDATOR_ENHANCEMENT_RECOMMENDATIONS.md— keeping this here is fine- JHS demography fix is a reasonable drive-by correction
One minor comment on the manifest filename below.
amc-corey-cox
added a commit
that referenced
this pull request
Feb 25, 2026
Regenerate uuid5 transformation on top of v35 (PR #358). Adds deterministic Visit identifiers for longitudinal linking: - Type A (1771 blocks): static visit value → uuid5 expr - Type B (373 blocks): value_mappings → uuid5 + case() expr - Type C (35 blocks): visit.yaml id field insertion Blocks with UNKNOWN participant are left unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
amc-corey-cox
added a commit
that referenced
this pull request
Feb 25, 2026
The v35 merge (PR #358) systematically changed associated_participant populated_from to match associated_visit populated_from in multi-visit blocks, overwriting the correct participant PHV with the visit PHV. Restores correct participant PHVs from v33 for 8 pht tables (234 blocks across 71 files) and updates the corresponding uuid5 str() expressions. pht002889 is excluded as it had a pre-existing duplicate that needs separate curator review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a massive set of changes. Take your time!