Experiment to test diagnostic noncompliance propagation#51
Conversation
in README. Created scenario files from prepare.py. Edited run_iteration.sh and summarize.py for new AWS S3.
sandypreiss
left a comment
There was a problem hiding this comment.
I think I see the issue here. This experiment is still installing crcsim from an older commit. (It looks like you copied the commit hash from exp-fqhc-diagnositic-compliance-comparison.)
Experiments use whatever version of crcsim is installed in the Docker image. That version is defined in pyproject.toml, which creates uv.lock, which is used to install the project in the Dockerfile.
So, even though this experiment branch has the new feature in the local code, it's running the experiment with an older version of crcsim. That means the propagate_diagnostic_noncompliance parameter is never used.
To resolve this:
- Update the
crcsimcommit hash inpyproject.tomlto the latest commit frommain(now that you've merged the noncompliance propagation branch in). You can get that by opening the commit history from the repo landing page. Just to be sure, it'sc4e08bffba34c07d18b784c0632de506a36611e8. - Update the comment in
pyproject.tomlto explain which commit you're installing from and why. - From
crcsim/experiment, runuv lockto update the lockfile. - Proceed with the normal steps to run the experiment (including rebuild and push).
I also added a few small style suggestions.
|
@sandypreiss Those updates should be applied. |
|
@sandypreiss I have updated the scenarios here with the hispanic male and female parameters added and removed extra low and low cost scenarios since I don't believe that will impact this analysis. |
|
This is looking good. Have you run it yet? Are we seeing the effect we'd expect from diagnostic noncompliance propagation now? |
|
I am currently running it. I had a bit of a problem running it last week because of the race specific mean_duration_clin but have rectified it. I hope to have results to send over tomorrow. |
|
This was run successfully. Results need to be pushed and a brief summary added to experiment readme. |
|
Updated with results and scenario files. |
in README. Created scenario files from prepare.py. Edited run_iteration.sh and summarize.py for new
AWS S3.
CRCsim PR Template
Description
PR Type
Experiment review checklist
exp-prefixcrcsimcommit hash (typically, the latest commit in themainbranch). This ensures that the experiment uses the latest version of the model.parameters.jsonfileprepare.pyscript applies incidence rate ratio (IRR) adjustment if appropriate for this experiment - NOT appliedprepare.pyand:scenarios/directory (eg, uncommitted local changes from a previous experiment)crcsim/experiment/README.mdwith detailed information about the experiment's goals, scenarios, and corresponding AWS objectsExperiment review process
All experiments must follow each step of this review process.
prepare.py, and spot-checking scenarioscrcsim/experiment/summarize.py)crcsim/experiment/summary/summarized.xlsx)Note that experiment PRs are never merged into
main! The PR is closed, and the experiment is maintained as a separate branch. That's why we keep all experiment PRs as drafts.