Exp accsis scenarios

[korourke5]

CRCsim PR Template

Description

This PR is opened to create a script that runs multiple Initial and diagnostic screening compliances from ACCSIS sites.

PR Type

• Feature (intended to merge)
• Experiment (not intended to merge)

Experiment review checklist

• This experiment branch has the exp- prefix
• This experiment uses the appropriate crcsim commit hash (typically, the latest commit in the main branch). This ensures that the experiment uses the latest version of the model. - Uses old hash
• This experiment uses the correct baseline parameters.json file
  • Correct screening start and end ages for the experiment
  • Latest values of all calibrated parameters
  • {X] All necessary tests and latest test parameters
  • Latest cost parameters
• My prepare.py script applies incidence rate ratio (IRR) adjustment if appropriate for this experiment
• I have run prepare.py and:
  • Confirmed that all scenarios necessary for this experiment were created
  • Confirmed that no extraneous scenarios are in the scenarios/ directory (eg, uncommitted local changes from a previous experiment)
  • Spot-checked a sample of scenario parameter files to ensure that my scenario creation logic works as expected
• I have updated crcsim/experiment/README.md with detailed information about the experiment's goals, scenarios, and corresponding AWS objects
• I am opening this PR as a Draft PR

Experiment review process

All experiments must follow each step of this review process.

1. Contributor checks all items in experiment review checklist
2. Contributor opens Draft PR and tags a collaborator to review
3. Reviewer conducts a thorough review, including pulling experiment branch, running prepare.py, and spot-checking scenarios
4. Contributor and reviewer address any issues identified during review
5. Reviewer explicitly approves PR
6. Contributor builds image and pushes to ECR, copies experiment files to S3, and runs experiment
7. Contributor analyzes experiment (eg crcsim/experiment/summarize.py)
8. Contributor pushes results summary, so we have documentation of detailed results (eg crcsim/experiment/summary/summarized.xlsx)
9. Contributor updates experiment README with a detailed summary of results
10. Contributor closes this PR with an informative comment (eg, brief summary of results)

Note that experiment PRs are never merged into main! The PR is closed, and the experiment is maintained as a separate branch. That's why we keep all experiment PRs as drafts.

[korourke5]

I see the Lint and Formatting is failing but it seems to be failing on a file that is not present in the repo.

[sandypreiss]

This worked for NC only because you have a single item in each compliance rate dict. Needs changes to handle additional sites without extraneous scenarios - see comments.

The linting error is caused by a notebook in the target branch. (TIL default behavior is to checkout code from the merge commit, not the feature branch) You can ignore the, since we're not going to merge this experiment branch.

[korourke5]

Thank you, Sandy. The code should be updated with those changes.

[sandypreiss]

Much cleaner! This should be ready to handle additional states.

I added a couple more nits to help you get familiar with more python conventions.

[korourke5]

These have been updated. It is failing one check due to a python notebook that will later be used/updated.

[sandypreiss]

Final ACCSIS runs pending additional site input data. Closing this PR because the experiment logic is all set.