Write tests for test-combining module#53
Merged
sandypreiss merged 3 commits intomainfrom Oct 22, 2025
Merged
Conversation
Tweaks for consistency and clarity in test_combine_tests.py - comments, docstrings, variable naming, etc
20 tasks
korourke5
approved these changes
Oct 22, 2025
Collaborator
korourke5
left a comment
korourke5
left a comment
There was a problem hiding this comment.
Hi Sandy. I was able to run the tests from my machine and they passed. The tests seem to make sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write tests for test-combining module
Description
combine_tests.pygot merged a while back without being unit tested. We decided this was okay, because the logic is fairly simple. Now getting around to testing it appropriately.Closes #35
PR Type
Feature checklist