Skip to content

Comments

adds BelowPercentileEventDetection method#551

Merged
samland1116 merged 4 commits intomainfrom
538-add-methods-to-metrics-for-flow-below-a-threshold-or-percentile
Oct 14, 2025
Merged

adds BelowPercentileEventDetection method#551
samland1116 merged 4 commits intomainfrom
538-add-methods-to-metrics-for-flow-below-a-threshold-or-percentile

Conversation

@samland1116
Copy link
Contributor

  • Adds BelowPercentileEventDetection method and relevant tests
    • Though i thought having these broken out into two methods, was more straightforward, I am not loving the naming convention/output column names.
    • Any opinions on adding a below_toggle [bool] to the current PercentileEventDetection method that inverts the meaning of True/False? I'm conflicted

@samland1116 samland1116 added this to the v0.6 Release milestone Oct 8, 2025
@samland1116 samland1116 self-assigned this Oct 8, 2025
@samland1116 samland1116 added enhancement New feature or request v0.6-dev Denotes that the issue is meant to be merged into the v0.6-beta development branch. main This is an issue that is considered v0.5.0 maintenance and should be merged into main priority: High This is blocking work, let's get it done as soon as possible. labels Oct 8, 2025
@samland1116
Copy link
Contributor Author

still need to increment dev version after review

@samland1116 samland1116 merged commit 56b5f55 into main Oct 14, 2025
@samland1116 samland1116 deleted the 538-add-methods-to-metrics-for-flow-below-a-threshold-or-percentile branch October 14, 2025 20:24
samlamont pushed a commit that referenced this pull request Oct 15, 2025
* adds BelowPercentileEventDetection method

* fix error w metrics_tansforms test

* increment dev version to 0.5.1dev8 from 0.5.1dev7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request main This is an issue that is considered v0.5.0 maintenance and should be merged into main priority: High This is blocking work, let's get it done as soon as possible. v0.6-dev Denotes that the issue is meant to be merged into the v0.6-beta development branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants