corrects error with unpack_results argument#589
Merged
Conversation
Collaborator
|
I think the Seems like maybe we should remove them from the BootstrapBasemodel (or MetricsBasemodel?) so we only have to check the condition once. Maybe we can discuss next week |
samlamont
approved these changes
Dec 5, 2025
samlamont
added a commit
that referenced
this pull request
Dec 5, 2025
* corrects error with unpack_results argument * update bootstrap pydantic models --------- Co-authored-by: samlamont <sam.lamont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to get the unpack_results functionality to work as intended (prior to this update) like:
When applying the bootstrapper in
teehr.querying.metric_format.apply_aggregation_metrics(), we were not checking if thebootstrap.unpack_resultsattribute was set or not. The unpacking hinged solely on if you defined the argument when instantiating the metric function you are bootstrapping.I updated
teehr.querying.metric_format.apply_aggregation_metrics()to check the bootstrap attributes forunpack_results. This allows you to define theunpack_resultsarg when instantiating the bootstrap and/or when defining the metric you apply the bootstrap to (i.e. the code Matt attached in the issue works in addition to the above).