Fix Shannon Entropy: sum instead of mean#2165
Open
knife982000 wants to merge 1 commit intoRUCAIBox:masterfrom
Open
Fix Shannon Entropy: sum instead of mean#2165knife982000 wants to merge 1 commit intoRUCAIBox:masterfrom
knife982000 wants to merge 1 commit intoRUCAIBox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the computation of the Shannon Entropy metric used in the recommender system.
🐛 Bug
The original implementation incorrectly computed Shannon Entropy as the negative mean of p(x) * log(p(x)), which deviates from the standard definition of Shannon Entropy:
H(X) = -∑ p(x) * log(p(x))
✅ Fix
meanwithsumin the Shannon Entropy calculation to correctly reflect the definition.🧪 Tests
assertEqualtoassertAlmostEqualwith a delta of1e-15to account for minor discrepancies due to floating point precision.1e-15delta, confirming numerical accuracy.