Draft: 1.2.0 #2
Open
Draft: 1.2.0 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 2, 2022 16:00
- this is useful for dependent projects that want type safety - there's no way to import a json as a const type (where `subscribe` is stricter than `number`) so thats why the convert to js (see microsoft/TypeScript#32063)
- `_destroy` noops were removed since they prevent proper propagation of errors - not sure what this needed for backwards compat, but I assume it was added after node 10 defaulted `autoDestroy: true` - tweaked some types on constructor options - added a catch around the mid serializer fn, without which it would cause an unhandled rejection and silently stop working
ci: add github ci actions to build and test
fix: properly destroy streams when an error occurs
see the comments on this MR st-one-io#41
…keys Fix MID 0002 Implementation
the `this` context might be lost, but that was also the case before this change
calling the callback passed to `_destroy` is not explicity mentioned as required in the nodejs docs, but it's necessary for error propagation. this is why the tests listening for an error event from link layer would fail, because even though the link layer would be destroyed, it would not emit an error event.
Add subscription error codes to mid groups (RV develop)
Fix LinkLayer _destroy
this unit test was failing because the error is emitted synchronously when calling `parser.write` It's functionality provided by nodejs internals, so it's a little weird to test for this in the first place
RedViking fork stuff
Fix test on Open Protocol Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thoughts / todo