fix: conflict between global aria2 RPC configuration and aria2c command-line #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)
Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.
Ensure you can run the codes you submitted succesfully. These submissions will be prioritized for review:
Introduce improvements in program execution speed;
Introduce improvements in synthesis quality;
Fix existing bugs reported by user feedback (or you met);
Introduce more convenient user operations.
PR type
Description
The
dlmodels.shscript usesaria2cto download models. When a global aria2 configuration (~/.aria2/aria2.conf) exists, thearia2ccommand line reads the global configuration. If the global configuration specifies enabling RPC (which is a common scenario, as global configurations are typically used for aria2's service mode), thearia2ccommand line will also attempt to create an RPC service, resulting in a port conflict. The solution is to add--enable-rpc=falseto the command line to disable the RPC option for the command-line execution.