Fix crash when model has no clipping masks#27
Merged
RaSan147 merged 3 commits intoRaSan147:masterfrom Apr 28, 2025
Merged
Conversation
Owner
|
Thanks a lot, I had little to no knowledge in the underlying render pipeline. Will test and approve. |
Owner
|
Can you kindly run the CI action in your repo and share the link. Then we can approve |
Author
|
Hi @RaSan147 , I found that the previous failure was caused by an incorrect The workflow runs successfully in my fork. Could you please click “Approve and run” so the CI can execute on this PR? Thanks for your help! |
Owner
|
Looks good, merging. Thanks a lot for all your help. 🤩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models that contain zero clipping masks do not create renderer._clippingManager, so the first frame threw:
Added an early-return guard:
Nothing changes when a clipping manager is present; models without masks now load and render normally.
This appears to address the same symptom described in #12
I would appreciate your review—thank you!