Skip to content

fix(tests): update failing test_get_available_budget #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadCod3 merged 1 commit into from
Jan 18, 2026
+8 −10
Merged

fix(tests): update failing test_get_available_budget #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions tests/integration/test_budgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from fastmcp import Client
from inline_snapshot import snapshot

from lampyrid.models.lampyrid_models import Budget, BudgetSpending, BudgetSummary
from lampyrid.models.lampyrid_models import AvailableBudget, Budget, BudgetSpending, BudgetSummary


@pytest.mark.asyncio
Expand Down Expand Up @@ -149,9 +149,6 @@ async def test_get_budget_summary(mcp_client: Client):
@pytest.mark.asyncio
@pytest.mark.budgets
@pytest.mark.integration
@pytest.mark.xfail(
reason='Firefly III API bug - currency_id returned as int instead of string (issue #43)'
)
async def test_get_available_budget(mcp_client: Client):
"""Test getting available budget for a period."""
# Use current month
Expand All @@ -162,13 +159,14 @@ async def test_get_available_budget(mcp_client: Client):
end = next_month.replace(day=1) - timedelta(days=1)

result = await mcp_client.call_tool(
'get_available_budget', {'req': {'start': start.isoformat(), 'end': end.isoformat()}}
'get_available_budget',
{'req': {'start_date': start.isoformat(), 'end_date': end.isoformat()}},
)
available = result.data
available = AvailableBudget.model_validate(result.structured_content)

# Should return available budget information
# amount may be 0 if no available budget is set
assert available['amount'] >= 0
assert available['currency_code'] is not None
assert available['start_date'] == start.isoformat()
assert available['end_date'] == end.isoformat()
assert available.amount >= 0
assert available.currency_code is not None
assert available.start_date.isoformat() == start.isoformat()
assert available.end_date.isoformat() == end.isoformat()