now options are not added to config

Author: RafaelGB

src/components/ColorPicker.tsx

@@ -6,7 +6,6 @@ import { castHslToString } from "./styles/ColumnWidthStyle";
 export function ColorPicker(colorPickerProps: ColorPickerProps) {
   const { view, options, option, columnKey } = colorPickerProps;
   const [colorState, setColorState] = React.useState(option.backgroundColor);
-  const [labelState, setLabelState] = React.useState(option.label);
   const [showColorPicker, setShowColorPicker] = React.useState(false);
   /**
    * Manage color picker
@@ -18,14 +17,15 @@ export function ColorPicker(colorPickerProps: ColorPickerProps) {
     setColorState(castHslToString(color.hsl));
     option.backgroundColor = castHslToString(color.hsl);
   }
+
   async function handleChangeComplete(
     color: ColorResult,
     event: React.ChangeEvent<HTMLInputElement>
   ) {
     handleChange(color, event);
     setShowColorPicker(false);
     // Persist changes
-    await view.diskConfig.updateColumnConfig(columnKey, {
+    await view.diskConfig.updateColumnProperties(columnKey, {
       options: options,
     });
   }
@@ -36,7 +36,7 @@ export function ColorPicker(colorPickerProps: ColorPickerProps) {
         onClick={() => setShowColorPicker(!showColorPicker)}
         style={{ backgroundColor: colorState, padding: "5px" }}
       >
-        {labelState}
+        {option.label}
       </span>
       {showColorPicker && (
         <SketchPicker

src/components/modals/handlers/MediaDimensionsHandler.ts

@@ -3,14 +3,16 @@ import { AbstractColumnHandler } from "components/modals/handlers/AbstractColumn
 import { ColumnHandlerResponse } from "cdm/ModalSettingsModel";
 
 export class MediaDimensionsHandler extends AbstractColumnHandler {
-    settingTitle: string = 'Choose dimensions of embeded media';
+    settingTitle: string = 'Dimensions of embeded media';
     handle(columnHandlerResponse: ColumnHandlerResponse): ColumnHandlerResponse {
         const { column, containerEl, view, columnSettingsManager } = columnHandlerResponse;
         const dbSettings = view.plugin.settings;
         const { config } = column
         if (config.enable_media_view) {
             // Check if media_settings is enabled
             new Setting(containerEl)
+                .setName(this.settingTitle)
+                .setDesc("Choose dimensions of embeded media (heigthxwidth)")
                 .addText(text => {
                     text.setPlaceholder("Height")
                         .setValue(config.media_height.toString())

src/components/modals/handlers/SelectedColumnOptionsHandler.tsx

@@ -24,7 +24,7 @@ export class SelectedColumnOptionsHandler extends AbstractColumnHandler {
         backgroundColor: randomColor(),
       });
       // Persist changes
-      view.diskConfig.updateColumnConfig(column.key, {
+      view.diskConfig.updateColumnProperties(column.key, {
         options: options,
       });
       // Force refresh of settings
@@ -39,7 +39,7 @@ export class SelectedColumnOptionsHandler extends AbstractColumnHandler {
       .addText((text) => {
         text
           .setPlaceholder("label of option")
-          .setValue("")
+          .setValue(newLabel)
           .onChange(async (value: string): Promise<void> => {
             newLabel = value;
           });

src/services/DatabaseInfo.ts

@@ -89,7 +89,7 @@ export default class DatabaseInfo {
      * @param columnId 
      * @param properties 
      */
-    async updateColumnProperties<P extends keyof DatabaseColumn>(columnId: string, properties: Record<string, P>): Promise<void> {
+    async updateColumnProperties(columnId: string, properties: Partial<DatabaseColumn>): Promise<void> {
         const colToUpdate = this.yaml.columns[columnId];
         for (const key in properties) {
             colToUpdate[key] = properties[key];