Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit fe13505

Browse files
committed
filter modal
1 parent 596093e commit fe13505

File tree

3 files changed

+26
-15
lines changed

3 files changed

+26
-15
lines changed

src/components/modals/filters/handlers/AddNewFilterHandler.tsx

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ import { Notice } from "obsidian";
1717
import { AtomicFilter } from "cdm/SettingsModel";
1818
import Grid from "@mui/material/Grid";
1919
import { randomColor } from "helpers/Colors";
20+
import { t } from "lang/helpers";
2021

2122
export class AddNewFilterHandler extends AbstractHandlerClass<FiltersModalHandlerResponse> {
22-
settingTitle: string = "Add new filter";
23+
settingTitle: string = t("filters_modal_add_single_filter");
2324
handle(
2425
columnHandlerResponse: FiltersModalHandlerResponse
2526
): FiltersModalHandlerResponse {
@@ -40,10 +41,7 @@ const NewFiltersForm = (props: FiltersModalProps) => {
4041
const addConditionHandler = () => {
4142
// Check if there is a condition to add
4243
if (possibleColumns.length <= 0) {
43-
new Notice(
44-
"No columns available yet. Include a field in one of your notes before add a filter",
45-
3000
46-
);
44+
new Notice(t("filters_modal_add_group_filter_error_no_columns"), 3000);
4745
return;
4846
}
4947

@@ -59,10 +57,7 @@ const NewFiltersForm = (props: FiltersModalProps) => {
5957
const addGroupConditionHandler = () => {
6058
// Check if there is a condition to add
6159
if (possibleColumns.length <= 0) {
62-
new Notice(
63-
"No columns available yet. Include a field in one of your notes before add a filter",
64-
3000
65-
);
60+
new Notice(t("filters_modal_add_group_filter_error_no_columns"), 3000);
6661
return;
6762
}
6863

@@ -102,7 +97,7 @@ const NewFiltersForm = (props: FiltersModalProps) => {
10297
}}
10398
onClick={addConditionHandler}
10499
>
105-
Add filter
100+
{t("filters_modal_add_single_filter")}
106101
</Button>
107102
</Grid>
108103
<Grid item xs="auto" key={`Grid-add-group-filter`}>
@@ -119,7 +114,7 @@ const NewFiltersForm = (props: FiltersModalProps) => {
119114
}}
120115
onClick={addGroupConditionHandler}
121116
>
122-
Add group
117+
{t("filters_modal_add_group_filter")}
123118
</Button>
124119
</Grid>
125120
</Grid>

src/components/modals/filters/handlers/GroupFilterComponent.tsx

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import IconButton from "@mui/material/IconButton";
2323
import LabelComponent from "components/modals/filters/handlers/LabelComponent";
2424
import { Setting } from "obsidian";
2525
import { castHslToString, castStringtoHsl, randomColor } from "helpers/Colors";
26+
import { t } from "lang/helpers";
2627
type GroupFilterComponentProps = {
2728
group: FilterGroup;
2829
recursiveIndex: number[];
@@ -175,7 +176,9 @@ const GroupFilterComponent = (groupProps: GroupFilterComponentProps) => {
175176
key={`Grid-disabled-${level}-${recursiveIndex[level]}`}
176177
>
177178
<IconButton
178-
aria-label="enable/disable filter"
179+
aria-label={t(
180+
"filters_modal_add_group_filter_button_enable_tooltip"
181+
)}
179182
size="small"
180183
onClick={() =>
181184
commonModifyFilter(
@@ -194,7 +197,9 @@ const GroupFilterComponent = (groupProps: GroupFilterComponentProps) => {
194197
key={`Grid-remove-group-${level}-${recursiveIndex[level]}`}
195198
>
196199
<IconButton
197-
aria-label="delete"
200+
aria-label={t(
201+
"filters_modal_add_group_filter_button_delete_tooltip"
202+
)}
198203
size="small"
199204
onClick={() =>
200205
commonModifyFilter(
@@ -213,7 +218,9 @@ const GroupFilterComponent = (groupProps: GroupFilterComponentProps) => {
213218
key={`Grid-add-atomic-filter-${level}-${recursiveIndex[level]}`}
214219
>
215220
<IconButton
216-
aria-label="add atomic filter"
221+
aria-label={t(
222+
"filters_modal_add_group_filter_button_atomic_filter_tooltip"
223+
)}
217224
size="small"
218225
onClick={() =>
219226
commonModifyFilter(
@@ -232,7 +239,9 @@ const GroupFilterComponent = (groupProps: GroupFilterComponentProps) => {
232239
key={`Grid-add-group-filter-${level}-${recursiveIndex[level]}`}
233240
>
234241
<IconButton
235-
aria-label="add group filter"
242+
aria-label={t(
243+
"filters_modal_add_group_filter_button_group_filter_tooltip"
244+
)}
236245
size="small"
237246
onClick={() =>
238247
commonModifyFilter(

src/lang/locale/en.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,11 @@ export default {
107107
"add_row_modal_quick_options_desc_button_delete_notice_confirm": "Are you sure you want to delete {0}?",
108108
/** FILTERS MODAL */
109109
"filters_modal_title": "Table filters",
110+
"filters_modal_add_single_filter": "Add Filter",
111+
"filters_modal_add_group_filter": "Add Group",
112+
"filters_modal_add_group_filter_error_no_columns": "You need to add at least one column to the table to create a filter",
113+
"filters_modal_add_group_filter_button_atomic_filter_tooltip": "Add atomic filter",
114+
"filters_modal_add_group_filter_button_group_filter_tooltip": "Add group filter",
115+
"filters_modal_add_group_filter_button_delete_tooltip": "Delete group filter",
116+
"filters_modal_add_group_filter_button_enable_tooltip": "Enable/Disable group filter",
110117
};

0 commit comments

Comments
 (0)