Restore last position and size for new PiP windows#12
Open
nkestrel wants to merge 9 commits intoRafostar:mainfrom
Open
Restore last position and size for new PiP windows#12nkestrel wants to merge 9 commits intoRafostar:mainfrom
nkestrel wants to merge 9 commits intoRafostar:mainfrom
Conversation
Rafostar
requested changes
Nov 20, 2022
Owner
Rafostar
left a comment
Rafostar
left a comment
There was a problem hiding this comment.
Hi, Thanks for working on this. Unfortunately I have few performance related concerns with this implementation. Please see my review comments. Thanks again.
…nges differently.
Owner
I had some time now to test this a little too. This works with Firefox, but unfortunately breaks Clapper due to resizing PiP window animation. I would recommend simply excluding this behavior from Clapper app ID: |
|
Is there any update for this? Would be really nice to have for the Wayland session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feature request #3. Tested only with Firefox.