Merged
Conversation
- Fix some proxy support isssues. ElevenLabs-DotNet-Proxy 3.5.1 - Bug fixes and better logging support.
StephenHodgson
commented
Jul 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR bumps both core and proxy packages to version 3.5.1, fixes proxy‐related issues, and enhances logging and cancellation support.
- Updated internal settings property naming and references
- Added cancellation tokens and improved logging in the proxy endpoint
- Bumped package versions to 3.5.1 and updated release notes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ElevenLabs-DotNet/ElevenLabsClient.cs | Renamed ElevenLabsClientSettings property to Settings and updated XML docs |
| ElevenLabs-DotNet/ElevenLabs-DotNet.csproj | Upgraded package version to 3.5.1 and updated release notes |
| ElevenLabs-DotNet/Common/ElevenLabsBaseEndPoint.cs | Switched URL builder to use the new Settings property |
| ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs | Renamed parameter, added cancellation support, improved logging, and changed error serialization |
| ElevenLabs-DotNet-Proxy/Proxy/ElevenLabsProxy.cs | Configured console logging in host and web application setup |
| ElevenLabs-DotNet-Proxy/ElevenLabs-DotNet-Proxy.csproj | Upgraded proxy package version to 3.5.1 and updated release notes |
Comments suppressed due to low confidence (4)
ElevenLabs-DotNet/ElevenLabsClient.cs:29
- The XML doc
<see="Settings"/>points to the property instead of the type. Update it to<see cref="ElevenLabsClientSettings"/>to correctly document the parameter type.
/// Optional, <see cref="Settings"/> for specifying a proxy domain.
ElevenLabs-DotNet/ElevenLabsClient.cs:131
- [nitpick] The property name
Settingsis quite generic and may cause confusion. Consider renaming it toClientSettingsorElevenLabsClientSettingsfor clarity.
internal ElevenLabsClientSettings Settings { get; }
ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs:128
- Switching to
MessageandStackTracechanges the JSON error schema and could break existing consumers. Restore the original lowercase keys (messageandstackTrace) if backward compatibility is required.
var response = JsonSerializer.Serialize(new { error = new { e.Message, e.StackTrace } });
ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs:57
- This
return;causes an early exit and makes the subsequent local function definitions look unreachable. Remove it to improve readability and maintain the method’s logical flow.
return;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElevenLabs-DotNet-Proxy 3.5.1