Skip to content

ElevenLabs-DotNet 3.5.1#87

Merged
StephenHodgson merged 2 commits intomainfrom
development
Jul 1, 2025
Merged

ElevenLabs-DotNet 3.5.1#87
StephenHodgson merged 2 commits intomainfrom
development

Conversation

@StephenHodgson
Copy link
Copy Markdown
Member

@StephenHodgson StephenHodgson commented Jul 1, 2025

  • Fix some proxy support isssues.

ElevenLabs-DotNet-Proxy 3.5.1

  • Bug fixes and better logging support.

- Fix some proxy support isssues.

ElevenLabs-DotNet-Proxy 3.5.1
- Bug fixes and better logging support.
@StephenHodgson StephenHodgson requested a review from Copilot July 1, 2025 15:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps both core and proxy packages to version 3.5.1, fixes proxy‐related issues, and enhances logging and cancellation support.

  • Updated internal settings property naming and references
  • Added cancellation tokens and improved logging in the proxy endpoint
  • Bumped package versions to 3.5.1 and updated release notes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ElevenLabs-DotNet/ElevenLabsClient.cs Renamed ElevenLabsClientSettings property to Settings and updated XML docs
ElevenLabs-DotNet/ElevenLabs-DotNet.csproj Upgraded package version to 3.5.1 and updated release notes
ElevenLabs-DotNet/Common/ElevenLabsBaseEndPoint.cs Switched URL builder to use the new Settings property
ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs Renamed parameter, added cancellation support, improved logging, and changed error serialization
ElevenLabs-DotNet-Proxy/Proxy/ElevenLabsProxy.cs Configured console logging in host and web application setup
ElevenLabs-DotNet-Proxy/ElevenLabs-DotNet-Proxy.csproj Upgraded proxy package version to 3.5.1 and updated release notes
Comments suppressed due to low confidence (4)

ElevenLabs-DotNet/ElevenLabsClient.cs:29

  • The XML doc <see="Settings"/> points to the property instead of the type. Update it to <see cref="ElevenLabsClientSettings"/> to correctly document the parameter type.
        /// Optional, <see cref="Settings"/> for specifying a proxy domain.

ElevenLabs-DotNet/ElevenLabsClient.cs:131

  • [nitpick] The property name Settings is quite generic and may cause confusion. Consider renaming it to ClientSettings or ElevenLabsClientSettings for clarity.
        internal ElevenLabsClientSettings Settings { get; }

ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs:128

  • Switching to Message and StackTrace changes the JSON error schema and could break existing consumers. Restore the original lowercase keys (message and stackTrace) if backward compatibility is required.
                    var response = JsonSerializer.Serialize(new { error = new { e.Message, e.StackTrace } });

ElevenLabs-DotNet-Proxy/Proxy/EndpointRouteBuilder.cs:57

  • This return; causes an early exit and makes the subsequent local function definitions look unreachable. Remove it to improve readability and maintain the method’s logical flow.
            return;

@StephenHodgson StephenHodgson marked this pull request as ready for review July 1, 2025 15:07
@StephenHodgson StephenHodgson merged commit b6b9f37 into main Jul 1, 2025
4 checks passed
@StephenHodgson StephenHodgson deleted the development branch July 1, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants