-
Notifications
You must be signed in to change notification settings - Fork 24
Rename testdata.yaml to test_group.yaml and implement Test Case Configuration #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good to me just added 3 remarks |
Also took the time to replace some occurrences of test{case,group,node} with test{ ,_}{case,group,node}. Verified by grepping `(?<![Cc]heck)testdata` that the phrase "testdata" no longer occurs, except in upgrade.py.
7168ad9
to
e0d9c67
Compare
Thanks for the comments, I fixed them 😄 |
7db920b
to
d5b35c4
Compare
d5b35c4
to
9f53e63
Compare
Everything looks good to me :) |
Okay, I've finally found some time to verify that the updated # yaml-language-server: $schema=file:///home/maarten/git/contest/BAPCtools/support/schemas/generators_yaml_schema.json I've even found and fixed a little bug that has been in the schema for a while already 😛 Regarding the Cue schemata: we have a CI test script ( |
This PR renames
testdata.yaml
totest_group.yaml
(as defined here) and introduces Test Case Configuration .yaml files (as defined here).Additionally,
.hint
and.desc
files are no longer used: they should now be keys (hint:
anddescription:
, respectively) in the Test Case Configuration file.A lot has changed, and I think everything still works, but please verify 😇
bt upgrade
should also properly take care of both migrations, both indata/
and ingenerators.yaml
.A special request for @thorehusfeldt if you have the time (if not, also fine 🙂): can you double-check the schemas for
test_group.yaml
and<testcase>.yaml
with the latest version of the spec? 😄