Skip to content

Conversation

mpsijm
Copy link
Collaborator

@mpsijm mpsijm commented Aug 13, 2025

This PR renames testdata.yaml to test_group.yaml (as defined here) and introduces Test Case Configuration .yaml files (as defined here).
Additionally, .hint and .desc files are no longer used: they should now be keys (hint: and description:, respectively) in the Test Case Configuration file.

A lot has changed, and I think everything still works, but please verify 😇 bt upgrade should also properly take care of both migrations, both in data/ and in generators.yaml.

A special request for @thorehusfeldt if you have the time (if not, also fine 🙂): can you double-check the schemas for test_group.yaml and <testcase>.yaml with the latest version of the spec? 😄

@mpsijm mpsijm changed the title Test case yamls Rename testdata.yaml to test_group.yaml and implement Test Case Configuration Aug 13, 2025
@mpsijm mpsijm mentioned this pull request Aug 13, 2025
17 tasks
@mzuenni
Copy link
Collaborator

mzuenni commented Aug 14, 2025

Looks good to me just added 3 remarks

mpsijm added 3 commits August 14, 2025 21:57
Also took the time to replace some occurrences of test{case,group,node} with test{ ,_}{case,group,node}.
Verified by grepping `(?<![Cc]heck)testdata` that the phrase "testdata" no longer occurs, except in upgrade.py.
@mpsijm
Copy link
Collaborator Author

mpsijm commented Aug 14, 2025

Thanks for the comments, I fixed them 😄

@mpsijm mpsijm force-pushed the test-case-yamls branch 2 times, most recently from 7db920b to d5b35c4 Compare August 17, 2025 11:59
@mzuenni
Copy link
Collaborator

mzuenni commented Aug 18, 2025

Everything looks good to me :)

@mpsijm
Copy link
Collaborator Author

mpsijm commented Aug 27, 2025

Okay, I've finally found some time to verify that the updated generators_yaml_schema.json works properly in my editor 😄 Turns out it was as simple as adding this line at the top of some generators.yaml file (only works if your editor actually uses yaml-language-server under the hood):

# yaml-language-server: $schema=file:///home/maarten/git/contest/BAPCtools/support/schemas/generators_yaml_schema.json

I've even found and fixed a little bug that has been in the schema for a while already 😛

Regarding the Cue schemata: we have a CI test script (test/yaml/generators/test_schemata.sh) that runs cue vet on a bunch of generators.yaml files, so I assume that'll be all right 😄

@mpsijm mpsijm merged commit 5394b82 into RagnarGrootKoerkamp:draft Aug 27, 2025
3 checks passed
@mpsijm mpsijm deleted the test-case-yamls branch August 27, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants