Conversation
|
Hi, I am not sure I understand the intention of this PR. #157 will drop Also, removing form without a replacement does not make sense to me either - as long as #157 is not yet merged, we want to have |
|
By landing this change upstream we reduce the complexity and diff that needs to be analyzed when evaluating #157 which has already shown to be too complicated. I think it should focus on the Makefile -> build.rs migration as we can iron out these pieces separately. I'm not sure I understand the motivation to run Update: Example: |
|
#157 is getting close, so defer to that solution |
This is another stepping stone toward #157. I did not see any difference in build time on my machine when running
cargo check --all-features.It probably needs the same CI changes to build the example as #176, but I didn't want to duplicate them here. This change can be rebased once that one lands.