Upgrade rust-toolchain.toml to fix CVE-2022-46176 #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, I think there is nothing speaking against keeping our compiler version as close to upstream as possible. Unfortunately, it seems CI isn't passing for some MCUs. Without looking deeper into it, maybe this is related to #388? Paging @agausmann. |
|
Okay, I checked, the failure really is #388. @agausmann kindly started working on an upstream fix, see rust-lang/rust#106619. |
|
Writing just to let you known that the older toolchain is also causing some trouble with the most recent versions of the rust-analyzer, something about the lack of a proc-macro server in toolchains before 2022-07-29. Tested and the problem goes away with the toolchain introduced in this PR. |
|
Toolchain was finally upgraded in #427. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the used Rust toolchain to fix CVE-2022-46176, a security bug with SSH host key checking in cargo.
I haven't tested it fully, so I understand if you don't want to incorporate it yet. Because it's such a jump in versions, it may create other issues. You have a larger community of great users, maybe some can test it before pushing it to main.
I'd love for more selective cherry-picking of patches in Rust, but this is the world we live in.
Have a great day, and thank you for this wonderful project!