You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given the fact that the ATmega32U4 doesn't have a hardware serial, my gut reaction is that we don't need it. However, both of the existing ATmega32U4 boards do define default_serial. Am I incorrect in assuming that default_serial is used for the default hardware serial bus?
Other than verifying that the new arduino-micro examples work (they do), are there any other tests that you'd like me to run?
In particular: when I try running cargo build from the root directory, I get a ton of build errors. I get the same errors even without this PR applied (build_logs.txt). Is this an issue with my build environment, or is cargo build only expected to work when run from within an example package?
Ivan-Johnson
added a commit
to Ivan-Johnson/Custom-Game-Controller
that referenced
this pull request
Dec 20, 2025
Yeah, I think we still should do it. You can connect a separate USB-UART bridge to the RX/TX pins to talk to the board so it is nice to have the short-hand macro for setting up communication.
Other than verifying that the new arduino-micro examples work (they do), are there any other tests that you'd like me to run?
No, this is entirely fine. Running cargo build from the crate root is expected to fail, you must run it from inside each directory. But in the end, just let the CI run those build tests for you ;)
You can connect a separate USB-UART bridge to the RX/TX pins to talk to the board
Ah, that makes sense; I didn't realize until now that UART only works on those two pins in particular.
I've pushed an update that enabled default_serial. I don't have easy access to a USB-UART bridge of my own, but I have created an micro-usart.rs so that we can at least verify that it compiles successfully. I assume that's good enough; as best I can tell the Arduino Micro and Arduino Leonardo hardware boards are essentially identical aside from their physical sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Rahix, I've got a couple of questions:
Should we define
default_serial?Given the fact that the ATmega32U4 doesn't have a hardware serial, my gut reaction is that we don't need it. However, both of the existing ATmega32U4 boards do define
default_serial. Am I incorrect in assuming thatdefault_serialis used for the default hardware serial bus?Other than verifying that the new
arduino-microexamples work (they do), are there any other tests that you'd like me to run?In particular: when I try running
cargo buildfrom the root directory, I get a ton of build errors. I get the same errors even without this PR applied (build_logs.txt). Is this an issue with my build environment, or iscargo buildonly expected to work when run from within an example package?