Various Fixes and Improvements #23
Merged
+256
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate upwards why parsing failed.
These lints are too noisy or make suggestions that we do not prefer to use.
Due to the design patterns used in the active station implementation, some clippy lints become invalid. Disable them for this module.
This also allows us to get rid of a number of assertions along the way as those are now directly covered by the try_from() errors.
This helps showing where improved error handling still needs to be implemented.
Don't immediately panic when an out-of-range value is supplied to UserPrmDataType::write_value_to_slice() and functions using it.
For now just panic, this will need to be improved in the future.
…ser_prm setting Propagate all invalid situations during set_prm() or set_prm_from_text() to the user instead of panicking.
Add more assertions to ensure invalid calls to set_prm() and set_prm_from_text() never panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.