Skip to content

Alias library to from #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eelcoj merged 1 commit into from
Apr 17, 2025
Merged

Alias library to from #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rails_icons/helpers/icon_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
module RailsIcons
module Helpers
module IconHelper
def icon(name, library: RailsIcons.configuration.default_library, variant: nil, **arguments)
def icon(name, library: RailsIcons.configuration.default_library, from: library, variant: nil, **arguments)
RailsIcons::Icon.new(
name: name,
library: library,
library: from || library,
variant: variant,
arguments: arguments
).svg
Expand Down
6 changes: 6 additions & 0 deletions test/icon_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ class IconTest < ActiveSupport::TestCase
assert_match(/class="present"/, icon("academic-cap", class: ["present": true, "not-present": false]), "SVG should contain 'class=\"present\"'")
end

test "`from` alias for `library`" do
assert_nothing_raised do
icon("academic-cap", from: "heroicons")
end
end

test "setting variant, it returns a SVG" do
assert_nothing_raised do
icon("academic-cap", variant: "mini")
Expand Down
Loading