Display time promotion on client order page #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ecommerce-events failed.
|
lukaszreszke
reviewed
Dec 4, 2024
Collaborator
|
Request for the future, please separate commits into smaller pieces :) In this case, refactoring of reset -> remove could be separate commit from displaying the discounts |
lukaszreszke
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #410
Previously, when a client submitted an order and displayed this order, there was no information about the discounts he received. Now, on the client order show page, there is information about the discounts that were applied.
I also refactored some names that had "reset" to "remove", which I had overlooked during this pull request:
#422
I was thinking about creating another table for discounts, such as
client_orders_discounts, and storing the discounts there instead of keeping them in the same table asclient_orderas it is now. What do you think about this?