introduce process manager #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if optional `process` kwarg provided - call process with each event
The idea is to extract the code that is repeated in all processes. * initialization * subscriptions * loading/building state * acting The acting part is generate/call commands based on the current state The current state always reflects all events passed to the process manager so far (including the event passed to current call). ProcessManager class, which includes module should: * define State class * pass it to include directive, e.g.: `include Infra::ProcessManager.with_state(ProcessState)` * define `process_id(event)` method. It should extract process identifier from event payload * define `act` method. It's responsibility it to generate and call commands based on the current state
get the list of subscribed events from the ProcessManager class. It's available because of the new `subscribes_to` API
Let's try to use simple Data.define as process state - make it unmutable. The process should now define `apply(event)` method, which have to return new state based on the current state and passed event. I also tried to utilize pattern matching in `act`. Is it easier to read now?"
* put the business logic at the beginning * send the technical methods to the very bottom
❌ Deploy Preview for ecommerce-events failed.
|
porbas
force-pushed
the
introduce-process-manager
branch
from
da65802 to
ce3abd5
Compare
take advantage of the ability to call process with passed event in the `given` helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
giventest_helper