refactor three plus one free to use process manager #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
porbas
commented
Apr 14, 2025
porbas
commented
- migrate ThreePlusOneFree to use ProcessManager
- we need a fresh initial process state on each PM#call
- remove not needed guards; we check them earlier i the act method
because in the call method we're always building state from scratch - reading all events from the stream
❌ Deploy Preview for ecommerce-events failed.
|
We need to calculate eligible_free_product *after* event has been applied to state. With this modification, we can get rid of the artificial should_act flag in the state
Let's make mutant happy for now, and don't use this feature yet
Don't call two commands at once when free product need to be changed. Just remove current free product. A new free product will be established on the next process run, when servicing Pricing::FreeProductRemovedFromOrder
porbas
force-pushed
the
refactor-three_plus_one_free-to-use-process-manager
branch
from
342a9ae to
0f840f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.