Experiment 4 #440
Closed
Experiment 4 #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving this logic to model gives us false feeling about correct design, as we "encapsulate" the order logic.
Co-authored-by: Tomasz Stolarczyk <[email protected]>
Expiring an order should increase product stock level. The reason is that the order haven't been paid and the stock will not be send. Co-authored-by: Tomasz Stolarczyk <[email protected]>
Co-authored-by: Tomasz Stolarczyk <[email protected]>
Before changing this part of the code it is good to know that we are not going to break anything. In order to make testing easier I decided to add `id` of product to each table row
This model will be used as a source of truth for the Stock Level. It'll replace current Product Active Record stock level.
The idea for plugging in a new write model is that we want to begin its stream with migration event, that's why we check whether migration event is already in the stream We also use an advisory lock to avoid race conditions when adding the migration event. New tests were added to check whether the logic of Inventory::ProductService works correctly for all 3 cases.
From now on the Stock Level column of product will be updated by UpdateProductStockLevel. The reason is that the source of truth lays somewhere else now. Currently it is synchronous update, but it might be possible to move to async later.
Checkpoint will be used to store last processed event id to ensure idempotency
❌ Deploy Preview for ecommerce-events failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.