change offer calculations #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
porbas
commented
Apr 16, 2025
porbas
commented
- let time promotion last longer during the test
- publish more pricing info in ItemAdded/ItemRemoved event payloads
- fix free products test
- add more Pricing::Offer tests to extend coverage and kill mutants
- kill mutants
it's hard to debug if promotion ends in a second
* add base_price * add base_total_value and total_value. This is the preliminary step to remove Totals Calculation events in the future
I believe, they was broken before. In my opinion, total_value should take into account ALL products base_price, event these made free
✅ Deploy Preview for ecommerce-events ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WARNING. Events generated by add_item/remove_item helpers are not fully proper. The totals in their payloads can be invalid. This process doesn't care about totals, so tests are green. Isn't it a smell?
seems like it is something slightly different than discount it is a promotion? policy? when you get 3 items of same type, 4th one is free
Arrange section isn't correct, there's no real items in the order
it will be easier to revert it if that's the case
1. When 4 products are added (one is free) and 5th one is added 2. When 7 producs are added (one is free) and 8th is added as free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.