Delay loading ActiveRecord::Base for Rails #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlyobvious
force-pushed
the
lazy-load-active-record
branch
2 times, most recently
from
02e9961 to
bc44078
Compare
Reason: rails/rails#31285 In short: * when in Rails, let Rails load the models after it loads ActiveRecord itself * when not Rails, proceed as usual
mostlyobvious
force-pushed
the
lazy-load-active-record
branch
from
4ec000a to
07c8206
Compare
mostlyobvious
added a commit
that referenced
this pull request
Jul 9, 2025
Needs another take, this one was too simplistic.
NameError: uninitialized constant RubyEventStore::ActiveRecord::WithDefaultModels::EventInStream (NameError)
[Event, EventInStream]
^^^^^^^^^^^^^
Related:
#1906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
rails/rails#31285
In short:
when in Rails, let Rails load the models after it loads ActiveRecord
itself
when not Rails, proceed as usual