fix merged (antisplit) apk signing on release builds #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for catching that! I've tested this feature many times before but with debug builds too lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, I’m really sorry about this. I should’ve tested this on release builds when I did the feature PR. Because of this, I’m not sure how many releases went out with this bug unnoticed. We only tested this on debug builds where the issue doesn’t occur, as in debug builds ProGuard isn’t applied to classes, and they remain intact. However, in release builds, ProGuard interferes and performs some strange optimizations on the
apksiglibrary, which causes issues with any actions involving the library, like APK signing or verification. I realized this yesterday while working on another project and it hit me that we aren’t excluding this in File Explorer Compose (or Prism now xD), so here I am.To reproduce this, try converting any split APK files to a single APK with signing enabled. You’ll notice the output file isn’t properly signed, and neither our app nor other apps like MT recognize it as a valid APK file.
Lastly, the new UI and animations are fantastic! I absolutely love them. They've even inspired some design ideas for my project. Truly amazing work!