feat: Add promo code activation and history endpoints #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new endpoints for user interactions with promo codes:
- `POST /api/user/promo/{id}/activate`: Allows an authenticated user to activate a specific promo code. The activation is subject to several validation checks, including
promo targeting rules (age, country), promo activity status, and a new anti-fraud service verification.
- `GET /api/user/promo/history`: Retrieves a paginated list of promo codes that the current user has previously activated.
Key changes include:
- A `PromoActivateView` that handles the logic for activating a promo code, including validation and atomic updates to the promo's usage count or unique code status.
- A `PromoHistoryView` to display the user's activation history.
- A new `antifraud_service` module to communicate with an external anti-fraud system, complete with caching and retry logic.
- A `PromoActivationHistory` model to log each successful activation, linking users to the promos they've activated.
- Updates to `UserPromoDetailSerializer` to include an `is_activated_by_user` field, indicating if the user has already activated the promo.
- New URL patterns in `user/urls.py` to route to the new views.
This commit addresses minor formatting issues in the `user/antifraud_service.py` file to align with the project's ruff linting configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two new endpoints for user interactions with promo codes:
POST /api/user/promo/{id}/activate: Allows an authenticated user to activate a specific promo code. The activation is subject to several validation checks, including promo targeting rules (age, country), promo activity status, and a new anti-fraud service verification.GET /api/user/promo/history: Retrieves a paginated list of promo codes that the current user has previously activated.Key changes include:
PromoActivateViewthat handles the logic for activating a promo code, including validation and atomic updates to the promo's usage count or unique code status.PromoHistoryViewto display the user's activation history.antifraud_servicemodule to communicate with an external anti-fraud system, complete with caching and retry logic.PromoActivationHistorymodel to log each successful activation, linking users to the promos they've activated.UserPromoDetailSerializerto include anis_activated_by_userfield, indicating if the user has already activated the promo.user/urls.pyto route to the new views.