Skip to content

refactor(core, business): unify pagination and promo serializers with enhanced validation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

refactor(core, business): unify pagination and promo serializers with enhanced validation #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2ad2aa
refactor(core): Add base serializer for pagination params
RandomProgramm3r Jul 14, 2025
42ca243
refactor(business): Overhaul promo serializers and validation logic
RandomProgramm3r Jul 15, 2025
6d2482a
refactor(business): Enhance promo validation and data representation
RandomProgramm3r Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions promo_code/business/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,7 @@ def get_comment_count(self) -> int:
def get_used_codes_count(self) -> int:
if self.mode == business.constants.PROMO_MODE_UNIQUE:
return self.unique_codes.filter(is_used=True).count()
# TODO: COMMON Promo
return 0
return self.used_count

@property
def get_available_unique_codes(self) -> list[str] | None:
Expand Down
Loading