Store binding slots

[pusewicz]

Closes #324

[RandyGaul]

Awesome! So how can we know if the implementation here works as expected?

[bullno1]

This should be freed in cute_shader_free_result

[bullno1]

const int for consistency with the rest.

Also some C compilers (e.g: Clang) are strict about what is considered "constant expression" for static initializer used in CF_ShaderBytecode later

[bullno1]

const inst* const for the same reason.

[bullno1]

Awesome! So how can we know if the implementation here works as expected?

That's actually a tough question.

I recall that some engine actually runs the rendering and do image diff for simple static scenes.
It is probably possible to do something like that if it's just triangle and static sprites.

[bullno1]

Oh I only meant the global variable generated by the shader compiler.
Because they get used by the static initializer later.
This doesn't have to be const.

[pusewicz]

It actually has to, as otherwise the generated values cannot be assigned to the struct member:

static const char** const s_backbuffer_fs_bytecode_image_names = NULL;
static const int* const s_backbuffer_fs_bytecode_image_binding_slots = NULL;
static CF_ShaderUniformInfo* const s_backbuffer_fs_bytecode_uniforms = NULL;
static CF_ShaderUniformMemberInfo* const s_backbuffer_fs_bytecode_uniform_members = NULL;
static CF_ShaderInputInfo* const s_backbuffer_fs_bytecode_inputs = NULL;
static const CF_ShaderBytecode s_backbuffer_fs_bytecode = {
    .content = s_backbuffer_fs_bytecode_content,
    .size = 408,
    .shader_info = {
        .num_samplers = 0,
        .num_storage_textures = 0,
        .num_storage_buffers = 0,
        .num_images = 0,
        .image_names = s_backbuffer_fs_bytecode_image_names,
        .image_binding_slots = s_backbuffer_fs_bytecode_image_binding_slots,
        .num_uniforms = 0,
        .uniforms = s_backbuffer_fs_bytecode_uniforms,
        .num_uniform_members = 0,
        .uniform_members = s_backbuffer_fs_bytecode_uniform_members,
        .num_inputs = 0,
        .inputs = s_backbuffer_fs_bytecode_inputs,
    },
};

This is what it's generated as: static const int* const s_backbuffer_fs_bytecode_image_binding_slots = NULL;

And here it's being assigned:

.image_binding_slots = s_backbuffer_fs_bytecode_image_binding_slots,

So unless there's a better way of doing it, it has to stay as is?

[bullno1]

I mean the problem is not in the generated code.

The declaration in the struct member does not have to be const int*.
It can just be int* image_binding_slots.

It's only const int* const in the generated code because some compilers in C mode complains that static initializer has to be constant expression.

[bullno1]

So the cast to free is not necessary if it wasn't const in the struct in the first place.