-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add support for guild incidents #9590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rapptz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this API, there's no way to edit the incident data from a clean slate. What I mean is, if e.g. Guild.incidents_data is None because it's unset then there's no way to add new incident data.
I'm honestly unsure how I feel about the attribute as a whole, it does mirror the API as-is so it's not particularly controversial but it doesn't feel very ergonomic.
It would be nice if there was e.g. Guild.invites_paused() -> bool and Guild.dms_paused() -> bool helper functions. I don't know if the are_ prefix is good for these, it feels awkward.
Looks like I forgot to change the type but it does always return an instance of
Not sure either. Maybe the two fields should just be on |
Rapptz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is much better.
Co-Authored-By: Danny <[email protected]>
For some reason the Sphinx developers made breaking changes in minor versions
…atures/guild-incident-data
…atures/guild-incident-data
…atures/guild-incident-data
Rapptz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks.
Summary
This PR adds support for the
incidents_datafield on guilds.Relevant API Docs:
This was discussed in
discord.py >💬Guild incident data
Checklist