Skip to content

Report throwables #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v6-dev
Choose a base branch
from
Open

Report throwables #38

wants to merge 2 commits into from

Conversation

@adamtomat
Copy link
Member

@adamtomat adamtomat commented May 6, 2022 •
edited
Loading

Rather than only allowing Exceptions in the report and render methods in the exception handler, allow anything that is Throwable (e.g. TypeError)

@adamtomat adamtomat requested a review from joelambert May 6, 2022 14:00
@adamtomat adamtomat mentioned this pull request May 6, 2022
Open
@adamtomat adamtomat changed the base branch from master to v6-dev May 6, 2022 14:23
@adamtomat
Copy link
Member Author

adamtomat commented Jun 6, 2023

Note this requires users to update the theme too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelambert joelambert Awaiting requested review from joelambert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamtomat