Merged
Conversation
Member
|
@Jixabon nice work! tested and all changes passed. thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following was noticed as not functioning properly included with the proposed solution.
/ap.interface- Was matching "ctrl_interface" higher in the file. Tweaked the regex to make the line start with "interface" to match the proper line and return the correct value/ap.wpa_passphrase- escape error that vscode happend to mention when I went to run the command in a JS context/clients/{interface}.active_clients_amount- The list of arp_addresses was actually an array of lines instead of macs. Just used the same code from theget_active_clientsfunction