Skip to content

fix: avoid scrolling into view for mouse interactions. #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachel-fenichel merged 1 commit into from
Mar 24, 2025
Merged

fix: avoid scrolling into view for mouse interactions. #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/workspace_utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,15 @@ import * as Blockly from 'blockly/core';
* @param workspace The workspace to scroll the given bounds into view in.
*/
export function scrollBoundsIntoView(
originalBounds: Blockly.utils.Rect,
bounds: Blockly.utils.Rect,
workspace: Blockly.WorkspaceSvg,
) {
if (Blockly.Gesture.inProgress()) {
// This can cause jumps during a drag and it only suited for keyboard nav.
return;
}
const scale = workspace.getScale();

const bounds = originalBounds.clone();

// Add some padding to the bounds so the element is scrolled comfortably
// into view.
bounds.top -= 10;
bounds.bottom += 10;
bounds.left -= 10;
bounds.right += 10;

const rawViewport = workspace.getMetricsManager().getViewMetrics(true);
const viewport = new Blockly.utils.Rect(
rawViewport.top,
Expand All @@ -49,6 +44,14 @@ export function scrollBoundsIntoView(
return;
}

// Add some padding to the bounds so the element is scrolled comfortably
// into view.
bounds = bounds.clone();
bounds.top -= 10;
bounds.bottom += 10;
bounds.left -= 10;
bounds.right += 10;

let deltaX = 0;
let deltaY = 0;

Expand Down