fix: patch WorkspaceSvg.getGesture to handle keyboard drags #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393
Adds an additional monkeypatch to the workspace. The current
Gestureis always null during a keyboard drag, and trying to get a gesture also stops propagation and prevents default on the instigating event.Without this patch,
WorkspaceSvgautomatically creates a newGestureif none was found:The workspace then calls
handleWsStartwhen the event propagates to the workspace, andhandleWsStartcallsstopPropagationandpreventDefaulton the event.Since `handlWsStart is not called in the new approach, directly cancel propagation in the getter.
Additional information
As with anything marked as a monkeypatch, this will need formalization into core.