feat: show context menu on workspace #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Apr 11, 2025
src/actions/action_menu.ts
Outdated
| > = []; | ||
| let rtl: boolean; | ||
|
|
||
| // TODO: Pass this through the precondition and callback instead of making it up. |
Collaborator
There was a problem hiding this comment.
File an issue and link
maribethb
merged commit a917f08
into
RaspberryPiFoundation:action-menu
1 of 2 checks passed
maribethb
added a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #362
Updates the context menu keyboard action to use new bits of the API in core. notably, don't have to calculate a location for blocks because core does that now.
Also, show the context menu on the workspace since core can support doing that with a keyboard event now.
This PR is paired with RaspberryPiFoundation/blockly#8877 and you'll need to link blockly to a version with that PR submitted in order for the exp to load once both of these are submitted.