Skip to content

Conversation

@maribethb
Copy link
Collaborator

Fixes #360

Implements the Connection context menu items without the hacks. Depends on RaspberryPiFoundation/blockly#8882, tests pass locally when they're linked.

Note that in core Connections don't implement the IContextMenu interface yet, so we still call the contextmenu.show method manually. Fixing that is coming soon. But this removes the hacks around including the connection in the scope and manually checking the precondition functions.

@maribethb maribethb requested a review from a team as a code owner April 14, 2025 20:50
@maribethb maribethb requested review from gonfunko and removed request for a team April 14, 2025 20:50
@maribethb maribethb merged commit 06b8665 into RaspberryPiFoundation:main Apr 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the "connection" action menu items using the new context menu api

2 participants