feat: add connection items without hacks #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360
Implements the Connection context menu items without the hacks. Depends on RaspberryPiFoundation/blockly#8882, tests pass locally when they're linked.
Note that in core
Connections don't implement theIContextMenuinterface yet, so we still call thecontextmenu.showmethod manually. Fixing that is coming soon. But this removes the hacks around including the connection in the scope and manually checking the precondition functions.