-
Notifications
You must be signed in to change notification settings - Fork 13
feat: enable blocks on drag #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import * as Blockly from 'blockly/core'; | ||
|
|
||
| const lastBlockDisabledReasons: Map<string, Set<string>> = new Map(); | ||
|
|
||
| /** | ||
| * A change listener that enables disabled blocks when they | ||
| * are dragged, and re-disables them at the end of the drag. | ||
| * | ||
| * @param event Blockly event | ||
| */ | ||
| export function enableBlocksOnDrag(event: Blockly.Events.Abstract) { | ||
| // This listener only runs on Drag events that have a valid | ||
| // workspace and block id. | ||
| if (!isBlockDrag(event)) return; | ||
| if (!event.blockId) return; | ||
| const eventWorkspace = Blockly.common.getWorkspaceById( | ||
| event.workspaceId, | ||
| ) as Blockly.WorkspaceSvg; | ||
| const block = eventWorkspace.getBlockById(event.blockId); | ||
| if (!block) return; | ||
|
|
||
| const oldUndo = Blockly.Events.getRecordUndo(); | ||
| Blockly.Events.setRecordUndo(false); | ||
|
|
||
| if (event.isStart) { | ||
| // At start of drag, reset the lastBlockDisabledReasons | ||
| lastBlockDisabledReasons.clear(); | ||
|
|
||
| // Enable all blocks including childeren | ||
| enableAllDraggedBlocks(block); | ||
| } else { | ||
| // Re-disable the block for its original reasons. If the block is no | ||
| // longer an orphan, the disableOrphans handler will enable the block. | ||
| redisableAllDraggedBlocks(block); | ||
| } | ||
|
|
||
| Blockly.Events.setRecordUndo(oldUndo); | ||
| } | ||
|
|
||
| /** | ||
| * Enables all blocks including children of the dragged blocks. | ||
| * Stores the reasons each block was disabled so they can be restored. | ||
| * | ||
| * @param block | ||
| */ | ||
| function enableAllDraggedBlocks(block: Blockly.BlockSvg) { | ||
| // getDescendants includes the block itself. | ||
| block.getDescendants(false).forEach((descendant) => { | ||
| const reasons = new Set(descendant.getDisabledReasons()); | ||
| lastBlockDisabledReasons.set(descendant.id, reasons); | ||
| reasons.forEach((reason) => descendant.setDisabledReason(false, reason)); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Re-disables all blocks using their original disabled reasons. | ||
| * | ||
| * @param block | ||
| */ | ||
| function redisableAllDraggedBlocks(block: Blockly.BlockSvg) { | ||
| block.getDescendants(false).forEach((descendant) => { | ||
| lastBlockDisabledReasons.get(descendant.id)?.forEach((reason) => { | ||
| descendant.setDisabledReason(true, reason); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Type guard for drag events. | ||
| * | ||
| * @param event | ||
| * @returns true iff event.type is EventType.BLOCK_DRAG | ||
| */ | ||
| function isBlockDrag( | ||
| event: Blockly.Events.Abstract, | ||
| ): event is Blockly.Events.BlockDrag { | ||
| return event.type === Blockly.Events.BLOCK_DRAG; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.