Skip to content

chore: Remove now-obsolete call to connectionPreviewer.hidePreview #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpcallen merged 2 commits into from
Apr 29, 2025
Merged

chore: Remove now-obsolete call to connectionPreviewer.hidePreview #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d855419
chore: Remove now-obsolete call to connectionPreviewer.hidePreview
cpcallen Apr 28, 2025
c0669d3
fix: Remove unneded @ts-expect directives causing test failures
cpcallen Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/actions/mover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,6 @@ export class Mover {
dragStrategy.isNewBlock,
);

// Explicitly call `hidePreview` because it is not called in revertDrag.
// @ts-expect-error Access to private property connectionPreviewer.
dragStrategy.connectionPreviewer.hidePreview();

// Save the position so we can put the cursor in a reasonable spot.
// @ts-expect-error Access to private property connectionCandidate.
const target = dragStrategy.connectionCandidate?.neighbour;
Expand Down
2 changes: 0 additions & 2 deletions src/keyboard_drag_strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy {
// @ts-expect-error connectionCandidate is private.
this.connectionCandidate = this.createInitialCandidate();
this.forceShowPreview();
// @ts-expect-error block is private.
this.block.addIcon(new MoveIcon(this.block));
}

Expand Down Expand Up @@ -100,7 +99,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy {

override endDrag(e?: PointerEvent) {
super.endDrag(e);
// @ts-expect-error block is private.
this.block.removeIcon(MoveIcon.type);
}

Expand Down
Loading