Skip to content

feat(mover): Report keyboard moves to WorkspaceSvg #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpcallen merged 2 commits into from
May 3, 2025
Merged

feat(mover): Report keyboard moves to WorkspaceSvg #485

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96cba55
feat(mover): Report keyboard moves to WorkspaceSvg
cpcallen May 2, 2025
b71eaad
chore(Mover): Remove obsolete WorkspaceSvg monkey patching
cpcallen May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/actions/mover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export class Mover {
if (!DraggerClass) throw new Error('no Dragger registered');
const dragger = new DraggerClass(block, workspace);
// Record that a move is in progress and start dragging.
workspace.setKeyboardMoveInProgress(true);
const info = new MoveInfo(block, dragger);
this.moves.set(workspace, info);
// Begin drag.
Expand Down Expand Up @@ -157,6 +158,7 @@ export class Mover {
this.unpatchWorkspace(workspace);
this.unpatchDragStrategy(info.block);
this.moves.delete(workspace);
workspace.setKeyboardMoveInProgress(false);
// Delay scroll until after block has finished moving.
setTimeout(() => this.scrollCurrentBlockIntoView(workspace), 0);
return true;
Expand Down Expand Up @@ -203,6 +205,7 @@ export class Mover {
this.unpatchWorkspace(workspace);
this.unpatchDragStrategy(info.block);
this.moves.delete(workspace);
workspace.setKeyboardMoveInProgress(false);
// Delay scroll until after block has finished moving.
setTimeout(() => this.scrollCurrentBlockIntoView(workspace), 0);
return true;
Expand Down
Loading