chore: Add tests for focus after deletion. #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
Tests look good--please fix lint and remove .only to be able to merge.
The document linked above expects that deleting a block that's inside an inline input would result in the parent block being selected, and that's not what happens, instead the parent block's input connection is selected. This PR expects the currently implemented behavior.
Works for me. Cursor position after delete is discussed #254 and we can update the test to match the behaviour we agree on in discussion.
Just realized that other issue is currently closed. I meant RaspberryPiFoundation/blockly#8793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements unit tests described at https://docs.google.com/document/d/1pIIX5sKEG9f_NcWDIQJJEOMM7w7pQUf8eJoT3lrAElQ/edit?tab=t.0 for deleting blocks via keyboard commands.
The document linked above expects that deleting a block that's inside an inline input would result in the parent block being selected, and that's not what happens, instead the parent block's input connection is selected. This PR expects the currently implemented behavior.