feat: Allow visiting and activating icons via keyboard navigation. #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
reviewed
May 19, 2025
Collaborator
There was a problem hiding this comment.
Out of curiosity, which icons should now be navigable @gonfunko? I tried testing this + the Core change locally and I can't seem to navigate to mutator or comment icons (I didn't check warning icons).
BenHenning
approved these changes
May 20, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
I'm not sure what changed but everything seems working for me in testing this morning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with RaspberryPiFoundation/blockly#9072, this PR partly fixes #189. It allows icons to be visited and activated. Support for moving focus to icon bubbles will be forthcoming in future PRs. Navigation logic is tested in the core PR.