feat: align disconnect with move + mouse behaviours #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Single statement block to match move. Perhaps both could do multi-block with uppercase. - Just call unplug like the drag strategy does. This means the disconnected block ends up the current node. Previous (presumably accidental) behaviour was to select the connection in a way that can't normally be navigated to causing it to persist oddly.
microbit-matt-hillsdon
requested review from
cpcallen
and removed request for
a team
| const rootBlock = superiorConnection.getSourceBlock().getRootBlock(); | ||
| rootBlock.bringToFront(); | ||
| const healStack = !curNode.outputConnection?.isConnected(); | ||
| Events.setGroup(true); |
Collaborator
There was a problem hiding this comment.
Set the event group to false afterwards.
Contributor
Author
There was a problem hiding this comment.
Collaborator
|
Overall I'm happy with this--matching existing behaviour means we use well-tested codepaths. |
rachel-fenichel
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the disconnected block ends up the current node. Previous (presumably accidental) behaviour was to select the connection in a way that can't normally be navigated to causing it to persist oddly.
You could make a case for move mode too but it's all tangled up with the insert/paste/heuristic discussion so not considering here.
Demo: https://simpler-disconnect.blockly-keyboard-experimentation.pages.dev/