Ensure black on white for move indicator. #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes it in MakeCode's dark theme that sets color to white at a high level in the DOM which is then used on semi-transparent white here via currentColor. Seems reasonable to hardcoded the foreground if we do so for the background.
microbit-matt-hillsdon
requested review from
cpcallen
and removed request for
a team
Collaborator
|
@gonfunko: Can you take a look at this? I'm not quite sure why you used (Also, tsk for misspelling "colour" ;-) |
gonfunko
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the icon in MakeCode's nascent dark theme, which sets color to white at a high level in the DOM which is then used on semi-transparent white here via currentColor. Seems reasonable to hardcode the foreground if we do so for the white background.
Example of broken state in MakeCode:
If there are further styling demands here then a CSS class on the group might be helpful. Having said that, I think this icon looks OK in dark and light modes as-is.