test: allow testing of workspace comments #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
RoboErikG
approved these changes
Jun 23, 2025
Contributor
Author
|
Thanks for the review. Just a reminder that someone else will need to merge 🙏 |
Contributor
|
Whoops, I kicked off the tests and forgot to merge when they finished. Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
registerCommentOptionsso we can add workspace comments which are worth testing with keyboard navigation.Add the delete icon as that's a factor in navigation too.