test: add scenario with workspace and block comments #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aim is to illustrate a bug where a new workspace comment has different behaviour to one that's been loaded. Will also be useful once navigation is supported for comments themselves.
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
| * @param {string} scenarioString Which scenario to load. | ||
| */ | ||
| export const load = function (workspace, scenarioString) { | ||
| const scenarioMap = { |
Contributor
Author
There was a problem hiding this comment.
Alphabetised so I don't have to think too hard where new ones go.
Contributor
Author
|
Started to consider comment navigation more systematically on this doc, will get more micro:bit team input tomorrow. But I think we need to do something soon about the fact you can get trapped in block and workspace comments if you don't use the mouse. |
RoboErikG
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to illustrate a bug where a new workspace comment has different behaviour to one that's been loaded (the new Cmd+Enter shortcut seems not to work). Will also be useful once navigation is supported for comments themselves.
Demo: https://test-comments.blockly-keyboard-experimentation.pages.dev/?scenario=comments&toolbox=toolbox&renderer=zelos